Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http to https #913

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/includes/documents/Chrome.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ To run userscripts on Chrome, you normally need a manager extension such as Tamp
[githubFavicon]: https://assets-cdn.github.com/favicon.ico
[oujsFavicon]: https://raw.githubusercontent.com/OpenUserJs/OpenUserJS.org/master/public/images/favicon16.png
[chromeBrowser]: https://www.google.com/chrome/browser/
[wikipediaChrome]: http://www.wikipedia.org/wiki/Google_Chrome
[wikipediaChrome]: https://www.wikipedia.org/wiki/Google_Chrome
[chromeSupport]: https://support.google.com/chrome/
[tampermonkeyForChrome]: Tampermonkey-for-Chrome
[chromium]: Chromium
4 changes: 2 additions & 2 deletions views/includes/documents/Chromium.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ To run userscripts on Chromium, you normally need a manager extension such as Ta

[githubFavicon]: https://assets-cdn.github.com/favicon.ico
[oujsFavicon]: https://raw.githubusercontent.com/OpenUserJs/OpenUserJS.org/master/public/images/favicon16.png
[chromiumBrowser]: http://dev.chromium.org/Home
[wikipediaChromium]: http://www.wikipedia.org/wiki/Chromium_%28web_browser%29
[chromiumBrowser]: https://dev.chromium.org/Home
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site has a preference of http with optional https. -1

Comment by @Martii
Originally posted at https://github.com/GreenLunar/OpenUserJS.org/commit/df9d5b50022cdbecfeb96fcf1daca1a07459ef16#commitcomment-16372957

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL Sorry about the posting on the Commits (your repo) instead of the Files (this repo)... makes mental note to pay more attention to GHs ever changing features :)

[wikipediaChromium]: https://www.wikipedia.org/wiki/Chromium_%28web_browser%29
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site has a preference of upgrading to secure. +1

Comment by @Martii
Originally posted at https://github.com/GreenLunar/OpenUserJS.org/commit/df9d5b50022cdbecfeb96fcf1daca1a07459ef16#commitcomment-16372961

[chromiumSupport]: https://code.google.com/p/chromium/issues/list
[tampermonkeyForChromium]: Tampermonkey-for-Chromium
6 changes: 3 additions & 3 deletions views/includes/documents/Opera.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ To run userscripts on Opera, you normally need a manager extension such as Tampe
[githubFavicon]: https://assets-cdn.github.com/favicon.ico
[oujsFavicon]: https://raw.githubusercontent.com/OpenUserJs/OpenUserJS.org/master/public/images/favicon16.png
[chrome]: Chrome
[operaBrowser]: http://www.opera.com/computer
[wikipediaOpera]: http://www.wikipedia.org/wiki/Opera_%28web_browser%29
[operaHelp]: http://www.opera.com/help
[operaBrowser]: https://www.opera.com/computer
[wikipediaOpera]: https://www.wikipedia.org/wiki/Opera_%28web_browser%29
[operaHelp]: https://www.opera.com/help
[tamperMonkeyForOpera]: Tampermonkey-for-Opera
[violentmonkeyForOpera]: Violentmonkey-for-Opera
4 changes: 2 additions & 2 deletions views/includes/documents/QupZilla.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ QupZilla ships with its own port of Greasemonkey as an extension.

[githubFavicon]: https://assets-cdn.github.com/favicon.ico
[oujsFavicon]: https://raw.githubusercontent.com/OpenUserJs/OpenUserJS.org/master/public/images/favicon16.png
[qupzillaBrowser]: http://qupzilla.com/
[wikipediaQupZilla]: http://www.wikipedia.org/wiki/QupZilla
[qupzillaBrowser]: https://qupzilla.com/
[wikipediaQupZilla]: https://www.wikipedia.org/wiki/QupZilla
[qupzillaHelp]: https://github.com/QupZilla/qupzilla/issues
2 changes: 1 addition & 1 deletion views/includes/documents/Tampermonkey-for-Android.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ Sometimes, when you use more than one userscript on the same web page, they need
[tampermonkeyAndroidScreenshot2]: https://raw.githubusercontent.com/wiki/OpenUserJS/OpenUserJS.org/images/tampermonkey_an3.png "Install via Tampermonkey"
[tampermonkeyAndroidScreenshot3]: https://raw.githubusercontent.com/wiki/OpenUserJS/OpenUserJS.org/images/tampermonkey_an4.png "Installing a script"
[tampermonkeyAndroidScreenshot4]: https://raw.githubusercontent.com/wiki/OpenUserJS/OpenUserJS.org/images/tampermonkey_an5.png "Tampermonkey Options"
[tampermonkeyNet]: http://tampermonkey.net/
[tampermonkeyNet]: https://tampermonkey.net/
[tampermonkeyForOpera]: Tampermonkey-for-Opera
[tampermonkeyForChrome]: Tampermonkey-for-Chrome
2 changes: 1 addition & 1 deletion views/includes/documents/Tampermonkey-for-Chromium.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Sometimes, when you use more than one userscript on the same web page, they need
[opera]: Opera
[tampermonkeyForAndroid]: Tampermonkey-for-Android
[gooChromeWebStoreTampermonkey]: https://chrome.google.com/webstore/detail/tampermonkey/dhdgffkkebhmkfjojejmpbldmpobfkfo
[tampermonkeyNet]: http://tampermonkey.net/
[tampermonkeyNet]: https://tampermonkey.net/
[tampermonkeyGooChromeWebStoreScreenshot]: https://raw.githubusercontent.com/wiki/OpenUserJS/OpenUserJS.org/images/tampermonkey_cr.gif "Tampermonkey in the Chrome Web Store"
[oujsScriptPageScreenshot1]: https://raw.githubusercontent.com/wiki/OpenUserJS/OpenUserJS.org/images/openuserjs_script.gif "Ready to install a script"
[tampermonkeyChromeScreenshot3]: https://raw.githubusercontent.com/wiki/OpenUserJS/OpenUserJS.org/images/tampermonkey_cr4.gif "Installing a script"
Expand Down
2 changes: 1 addition & 1 deletion views/includes/documents/Tampermonkey-for-Opera.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ Sometimes, when you use more than one userscript on the same web page, they need
[tampermonkeyOperaScreenshot3]: https://raw.githubusercontent.com/wiki/OpenUserJS/OpenUserJS.org/images/tampermonkey5.png "Tampermonkey Dashboard"
[tampermonkeyForAndroid]: Tampermonkey-for-Android
[tampermonkeyForChrome]: Tampermonkey-for-Chrome
[tampermonkeyNet]: http://tampermonkey.net/
[tampermonkeyNet]: https://tampermonkey.net/
8 changes: 4 additions & 4 deletions views/includes/documents/Terms-of-Service.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ Within moderation we understand the occasional necessity to conserve device stor

#### Default Code Licensing

* User Scripts have an implied license of [MIT License (Expat)](http://opensource.org/licenses/MIT) if the `@license` *(including the alternate spelling of `@licence`)* metadata block key is absent.
* Library Scripts need to include one reference to their [acceptable license(s)](#acceptable-licensing) either via a License Header *([sample MPL header](https://www.mozilla.org/MPL/headers/) if that license is chosen)*, a cross-site compatible metadata block with at least one `@license` or `@licence` key **and** one `@exclude *`, or full License text *(full text is not recommended for storage constraints on portable devices)*. Libraries also have an implied license of [MIT License (Expat)](http://opensource.org/licenses/MIT) in the absence of any licensing *(however this should not happen)*. It may also be useful to indicate in the source that it is a library and not a userscript. If the type of script is unclear the library may be subject to removal.
* User Scripts have an implied license of [MIT License (Expat)](https://opensource.org/licenses/MIT) if the `@license` *(including the alternate spelling of `@licence`)* metadata block key is absent.
* Library Scripts need to include one reference to their [acceptable license(s)](#acceptable-licensing) either via a License Header *([sample MPL header](https://www.mozilla.org/MPL/headers/) if that license is chosen)*, a cross-site compatible metadata block with at least one `@license` or `@licence` key **and** one `@exclude *`, or full License text *(full text is not recommended for storage constraints on portable devices)*. Libraries also have an implied license of [MIT License (Expat)](https://opensource.org/licenses/MIT) in the absence of any licensing *(however this should not happen)*. It may also be useful to indicate in the source that it is a library and not a userscript. If the type of script is unclear the library may be subject to removal.

#### Acceptable Licensing
* Licensing must be [Open Source Initiative *(OSI)* approved](http://opensource.org/licenses/category) and declared with the name of the License in the Source Code for all published works. e.g. `@license` or `@licence` keys, License Header or full License text *(full text is not recommended for storage constraints on portable devices)*
* Licensing must be [Open Source Initiative *(OSI)* approved](https://opensource.org/licenses/category) and declared with the name of the License in the Source Code for all published works. e.g. `@license` or `@licence` keys, License Header or full License text *(full text is not recommended for storage constraints on portable devices)*
* If a Content only license is included then the [Default Code Licensing](#default-code-licensing) will be applied with licensing arbitration, but may not always be visibly indicated on a script home page.
* Any license that prohibits derivatives is eligible for removal.
* Non-reusable licenses, of course, may not be used.
* [Public domain type](http://opensource.org/faq#public-domain) licenses may mean different things in different jurisdictions and therefore are not allowed and eligible for removal.
* [Public domain type](https://opensource.org/faq#public-domain) licenses may mean different things in different jurisdictions and therefore are not allowed and eligible for removal.
* Any attempt to unlicense a published work will be eligible for removal.
* In the event of any code licensing dispute resolution the [Default Code Licensing](#default-code-licensing) shall prevail if previously undeclared and/or undocumented.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 comments on commit df9d5b5

@Martii
Missing commit summary -1

@Martii
I won't bother doing the rest... but this shows you how we consider a PR.

@GreenLunar
No problems. Thank you very much.

@GreenLunar
To tell you the truth, I just wanted to raise this issue (if it is an issue at all), yet I did not want someone of the team members to wonder why they need to do despairing repetitive actions.

As far as I am concerned, I have done what I wanted to be done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet I did not want someone of the team members to wonder why they need to do despairing repetitive actions.

That's why issues should be made first... then discuss... etc... as I described at the PR itself first. That way you won't be doing repetitive actions e.g. unnecessary work. You did find one enhancement for wikipedia so that is something you could do with a probably +1 support for merging... issue first though.

Sidebar: With wikipedia links always watch that the link is language neutral too. Typically here in the US it will redirect to https://en.wikipedia.org and we shouldn't be linking to outside en only pages if they have their own browser language detection when possible. Same goes for Mozilla links and any others that apply.

Expand Down