Some visual notices for script minification issues #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a regular expression to use environment port if available ... this is a dev bug * Some prior typos and comments clarified * New OpenUserJS metadata block key of `unstableMinify`... following Scriptish example of camel casing *(interCaps)*. This requires a string after it which is the reason why... invalid reasons may reduce ones karma :) * Using boolean switch so that the view contains the strings and not the controller/libs side of our code... useful for OpenUserJS#18 and how views should eventually be rendered * Libraries aren't covered yet because of OpenUserJS#723 * `decodeURIComponent` is required as per OpenUserJS#819 ... do a trap for now just in case it fails... which may produce a false positive but these are just notices at this time Applies to OpenUserJS#432
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Feb 5, 2016
Some visual notices for script minification issues Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unstableMinify... following Scriptish example of camel casing (interCaps). This requires a string after it which is the reason why... invalid reasons may reduce ones karma :)decodeURIComponentis required as per FixinstallNamevsinstallNameSlugreferences #819 ... do a trap for now just in case it fails... which may produce a false positive but these are just notices at this timeApplies to #432