Support existing incompleted "reason" value for remove user and script #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* One reserved phrase of "User removed" *(any casing)* for automatic content removal when a User is removed. * Basic error checking... Moderators and above should be concise. * Abandoning previous UI since portable devices would barely show the input box... plus a few things have changed since initial attempt. * Leaving out the data list for now until it can be decided where to physically put and name it *(them?)* in the project tree... perhaps time for a user.js. Applies to OpenUserJS#261
Martii
added a commit
that referenced
this pull request
Jan 10, 2015
Support existing incompleted "reason" value for remove user and script Auto-merge with private sizzle approval to temporarily bypass section block in #262
Martii
added
security
| } | ||
|
|
||
| form = new formidable.IncomingForm(); | ||
| form.parse(aReq, function (aErr, aFields) { |
There was a problem hiding this comment.
formidable.parse() is async.
There was a problem hiding this comment.
Good to know... will get that after slumber too. Have another use case to get too. Thanks.
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Aug 4, 2015
* Done previously in OpenUserJS#654 for public sortings * Add some *font-awesome* icons to the graveyard * Transform "All Types" to the correct nomenclature of "Clear Filters" * Change `href` to use parent plus `/removed` e.g. `./removed` static * Made User removal reason virtual instead of hard-coded... useful for Search filters e.g. reason is now blank when system generated... still don't allow a blank reason from a real author.. post fix for OpenUserJS#261 and pull OpenUserJS#513. This allows no reserved phrases other than string empty. * Some STYLEGUIDE.md conformance * DB remove model **migrated** as far back as "User removed" existed * Added some common needed Filters and reordered similar to GH... not all are implemented yet Closes OpenUserJS#526
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Oct 15, 2015
* Base working concept * Eventual showing of the reason in respective views... currently set to a horizontal ellipsis if absent... see additional notes below Applies to OpenUserJS#643 and OpenUserJS#641 NOTES: * Test with QSP `?flagged=true` for lists and Admin or better privileges on script homepage and user homepage with logged in and logged out... there are at least 6 routes *(4 with QSP and 2 without but all elevated to Admin+)* needed to test against * If for some reason some user is flagged but there aren't any actual flags it will show up as no user and no reason e.g. Flagged column will be empty for those mustache opts * Using series in some of the *async* related calls to hopefully ensure natural ordered flags * **NOT COMPACTED** for clarity as well as for strict *async* usage * One bug fix in a view with colspan * One restoration in `.../modelParser.js` * Some class changes in a view TODO: *(mitigation)* * Needs reason attached to flagging route ... separate issue to be created and milestoned near OpenUserJS#485 and OpenUserJS#262 and similarly done in OpenUserJS#513
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Oct 26, 2015
* Change route to use regex and a POST... removed TODO note on it... **NOTE** `nav-pills` UI issue with form buttons... so making `Flag` and `Unflag` in their own div tag as intended * Establish a controller function to flag/unflag * Removed now dead code... aOptions and exports * Cleaned up remove controller function code a little bit to be more symmetrical... post OpenUserJS#510, OpenUserJS#513, OpenUserJS#514 with parent of OpenUserJS#261 e.g. e0929ca...e1e3f7e excluding OpenUserJS#511 * Some STYLEGUIDE.md conformance * Don't `return` some assumed `undefined`s in `aNext()`s and `statusCodePage()` Applies to OpenUserJS#775
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to #261
(Temporary #262 section block bypass approved by sizzle)