Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Mean + Median)/2 fix #1582

Merged
merged 1 commit into from
Feb 5, 2019
Merged

(Mean + Median)/2 fix #1582

merged 1 commit into from
Feb 5, 2019

Conversation

Martii
Copy link
Member

@Martii Martii commented Feb 5, 2019 •
edited
Loading

  • Referred to as a collective rating in the code... this value should be zero according to that routine. (...for groups that only have one script)
  • That routine already has this but I assume it's a "double check?" since aScripts can change on the fly... anyhow... groups with 1 script should have a "collective rating" of zero according to the function... so mirroring

Applies to #93 and post #1581

Also notating that getRating is called elsewhere directly.

Ref:

@Martii
(Mean + Median)/2 fix
41cb13e 
* Referred to as a collective rating in the code... this value should be zero according to that routine.
* That routine already has this but I assume it's a "double check?" since `aScripts` can change on the fly... anyhow... groups with 1 script should have a "collective rating" of zero according to the function... so mirroring

Applies to OpenUserJS#93 and post OpenUserJS#1581
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Feb 5, 2019
@Martii Martii merged commit 31d31bc into OpenUserJS:master Feb 5, 2019
@Martii Martii deleted the Issue-93fixRatingColumn branch February 5, 2019 15:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii