Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Code styling and refactor #1410

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Some Code styling and refactor #1410

merged 1 commit into from
Jun 8, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 8, 2018

  • Make this code look more like the others and place some in sessions lib
  • Remove some unused identifiers from prior patch
  • Retag some comments a bit
  • Some STYLEGUIDE.md compliance
  • Stop slinging around some functions on return again

Post #1393

@Martii
Some Code styling and refactor
34b762a 
* Make this code look more like the others and place some in sessions lib
* Remove some unused identifiers from prior patch
* Retag some comments a bit
* Some STYLEGUIDE.md compliance
* Stop slinging around some functions on return again

Post OpenUserJS#1393
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. DB Pertains inclusively to the Database operations. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 8, 2018
@Martii Martii merged commit b48dd88 into OpenUserJS:master Jun 8, 2018
@Martii Martii deleted the moveToLib branch June 8, 2018 07:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DB Pertains inclusively to the Database operations. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii