Proofread finished for the core directory

[thatbettina]

FYI: Portfolio 2 is still missing some stuff, like form elements.

[lehmannro]

This remark seems kinda lost. Can we further explain it, or at least say we're deferring the explanation of this?

[thatbettina]

Hi @lehmannro This might be a better remark for @gsambrotta because she wrote the text; I am just proofreading it as a native English speaker.

[lehmannro]

Line lengths are now a mumbo jumbo between capped-to-80-characters, 80-characters-plus-some-edits, and whole-paragraph-in-one-line. Could we rewrap?

[lehmannro]

Better encourage a semicolon here.

[thatbettina]

@lehmannro Where should the semicolon be?

[Ivoz]

@thatbettina it would be awesome if you could work on updating the fixes that Robert has suggested, he has done so through your changes. If you just push commits to your repo it will update the pull request with them here.

Otherwise I'd love to start working on this tutorial as well, but it would probably be easier if we can get your changes in beforehand.

You should be able to get my quick commit in with a git pull --rebase, I hadn't noticed this large PQ coming up.

[thatbettina]

I just updated the repo with Robert's fixes, with some exceptions. I've
commented on them on GitHub.

Sorry for the delay, but I just started a new job in mid-September and
haven't had time. Thanks for your patience!

On Mon, Sep 23, 2013 at 11:54 PM, Matt Iversen [email protected]:

@thatbettina https://github.com/thatbettina it would be awesome if you
could work on updating the fixes that Robert has suggested, he has done so
through your changes. If you just push commits to your repo it will update
the pull request with them here.

Otherwise I'd love to start working on this tutorial as well, but it would
probably be easier if we can get your changes in beforehand.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-24958422
.

Bettina Shzu-Juraschek
Fuldastraße 19-20
12045 Berlin

+49 (0)163 164 7045
[email protected]

[Ivoz]

You need to be aware that even using uppercase HTML in the document content, you shouldn't use uppercase for html elements, nor for file extensions, which broke most of the links.

If you install ruby and jekyll you can test out changes you've made on your own computer using the command jekyll serve -w in the git repo's base directory.

You can see the css is broken and links do not work on github's rendering of your own repo, at http://thatbettina.github.io/html-css-beginners/

Always try to make sure that the code you suggest for others to use is working when you submit it, this makes everyone happier.

I haven't fully finished vetting the changes but I intend to over the next week anyway.

Cheers

[thatbettina]

Thanks for the advice, @Ivoz

I need a big tutorial on how jekyll and GitHub pages work.

I installed jekyll and tried out the command jekyll serve -w but I got the error:

Error reading file /home/bettina/Sites/html-css-beginners/_layouts/ots.html: invalid byte sequence in US-ASCII
Error reading file /home/bettina/Sites/html-css-beginners/core/structure.md: invalid byte sequence in US-ASCII
Error reading file /home/bettina/Sites/html-css-beginners/core/portfolio-2.md: invalid byte sequence in US-ASCII

And I do see that that the links do not work on my repo :(

I will try to figure out what those errors are except that I see you already merged my pull request.

Did you also fix my code? If so, thanks so much for all your help!

If not, I will work on this before Saturday.

[Ivoz]

@thatbettina I pushed an commit which should hopefully tell ruby to use UTF-8.

You can also try fixing that issue by following this page's advice.

Yes, I merged and have fixed most mistakes that I have found for your pull request.

[Ivoz]

Also make sure your jekyll is up to date, if you have the bundle gem installed you can use bundle install to update to the jekyll that's set by Gemfile.lock