Change: add constants for FRAX cargo classes #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andythenorth
force-pushed
the
cargo-classes-2024
branch
from
ec41d33 to
74f696e
Compare
andythenorth
force-pushed
the
cargo-classes-2024
branch
from
74f696e to
036d0a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~12 years of current cargo classes shows that some are very useful and some are not.
FRAX clarifies or redefines a number of cargo classes, and will be supported in FIRS and Iron Horse. https://grf.farm/polar_fox/frax_latest.html
Providing constants matching FRAX reduces friction for grf authors. Alternately I can provide a constants file for them to import to their nml, but that's the same result for more friction :)