Add: Support for faster ship speed 23 and acceleration 24 (OTTD #10734) #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Jan 29, 2024
nml/actions/action0properties.py
Outdated
|
|
||
| # prop 23 should not be set if value(prop0B_value) <= 255. | ||
| def prop23_test(value): | ||
| return isinstance(value, ConstantNumeric) and value.value >= 0x00FF |
There was a problem hiding this comment.
Suggested change
| return isinstance(value, ConstantNumeric) and value.value >= 0x00FF | |
| return isinstance(value, ConstantNumeric) and value.value >= 0xFF |
zephyris
force-pushed
the
faster-ships
branch
from
2e2e8e8 to
719936c
Compare
glx22
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new ship Action0 properties from OTTD#10734. Add support for 0x24 byte for ship acceleration and 0x23 word for ship speed, the latter only set if speed is >255 thus does not fit in the existing 0x0B byte for ship speed.
(This seems to work as expected, but is my first time trying to update nml - I may well have made mistakes/be wrong!)