Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Actions] nmlc version could not be determined during regression #285

Merged
merged 1 commit into from
May 21, 2023

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 18, 2023

Regression log is very noisy with each test triggering

fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
Git checkout found but cannot determine its version. Error:  Command '['git', '-C', '/Users/runner/work/nml/nml', 'describe', '--tags', '--long']' returned non-zero exit status 128.
Git checkout found but cannot determine its version. Error:  Command '['git', '-C', '/Users/runner/work/nml/nml', 'describe', '--tags', '--long']' returned non-zero exit status 128.

Fetch more data during checkout so git describe can do its job.

@@ -26,6 +26,13 @@ jobs:

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because with default depth (1), you only get the merge commit, and its relation with last tag is impossible to find

@glx22 glx22 merged commit a80235a into OpenTTD:master May 21, 2023
@glx22 glx22 deleted the regression branch May 21, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants