Feature: Engine name callback #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Jan 31, 2023
This does not include the D8xx text area extension.
glx22
approved these changes
Jan 31, 2023
|
nml spec updated https://newgrf-specs.tt-wiki.net/wiki/NML:Vehicles#Vehicle_callbacks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See OpenTTD/OpenTTD#10399.
Add basic support for the engine name callback and the extended callback flag properties.
Limitations
To make full use of the name callback in view of the limited D0xx text are that is available as a callback results, the OpenTTD PR also increases the D8xx text are up to FFFF (using up some TTDpatch specific IDs). Inclusion via the text stack and codes 80/81 can use all IDs and thus also D8xx.
So far, NML can not make use of this though, as all strings that are referred from Action 2s seem to be strictly allocated into the D0xx area. Reworking this is above my pay grade and thus not part of this PR.