Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: 'tunnels' callback for road- and tramtypes #273

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Add: 'tunnels' callback for road- and tramtypes #273

merged 1 commit into from
Dec 25, 2022

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Dec 13, 2022

This addition reflects OpenTTD/OpenTTD#10233

Usage is the same as railtype tunnels.

FLHerne
FLHerne approved these changes Dec 25, 2022
View reviewed changes
Copy link
Contributor

@FLHerne FLHerne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the vague tunnels name, but it matches the one in railtypes like most of the other roadtype names. I'd have suggested tunnel_overlay but that's already used in railtypes for portal overlays so would be much more confusing.

@glx22 glx22 merged commit efedff6 into OpenTTD:master Dec 25, 2022
@glx22 glx22 deleted the NRT_tunnel_ground branch December 25, 2022 23:12
@andythenorth
Copy link
Contributor

Added to nml spec https://newgrf-specs.tt-wiki.net/wiki/NML:Roadtypes#Roadtype_callbacks

Somebody had already add it, but commented out - thanks, saved time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FLHerne FLHerne FLHerne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glx22 @andythenorth @FLHerne