Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More issues in release workflow #271

Merged
merged 2 commits into from
Dec 3, 2022
Merged

More issues in release workflow #271

merged 2 commits into from
Dec 3, 2022

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Dec 3, 2022

Adding --verbose to pip command helped to find the manylinux issue, keeping it will not hurt :)
Manylinux issue was

 fatal: detected dubious ownership in repository at '/github/workspace'
 To add an exception for this directory, call:

 	git config --global --add safe.directory /github/workspace
 fatal: detected dubious ownership in repository at '/github/workspace'
 To add an exception for this directory, call:

 	git config --global --add safe.directory /github/workspace
 Git checkout found but cannot determine its version. Error:  Command '['git', '-C', '/github/workspace', 'diff-index', 'HEAD']' returned non-zero exit status 128.

So no surprised it decided to use 0.0.0 as version.

While fixing stuff set-output is deprecated.
Will also need to replace actions/upload-release-asset as it's not maintained and uses deprecated node.js (but no hurry with our not so frequent releases)

@glx22 glx22 force-pushed the release branch 2 times, most recently from 6a65b76 to 4f4049f Compare December 3, 2022 23:26
@glx22 glx22 merged commit a07ab7d into OpenTTD:master Dec 3, 2022
@glx22 glx22 deleted the release branch December 3, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants