Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version_openttd needs adjusting for OpenTTD >= 12 #295

Closed
frosch123 opened this issue Jun 27, 2023 · 2 comments
Closed

version_openttd needs adjusting for OpenTTD >= 12 #295

frosch123 opened this issue Jun 27, 2023 · 2 comments

Comments

@frosch123
Copy link
Member

frosch123 commented Jun 27, 2023 •
edited
Loading

version_openttd still follows the old 1.x.y versioning schema of OpenTTD.

People started working around this by testing for 1.12, 1.13, 1.14 instead for 12.0, 13.0 and 14.0: https://newgrf-specs.tt-wiki.net/index.php?title=NML:General&curid=340&diff=4465&oldid=4261

But this will only work till 15.0.
For 16.0 one would need version_openttd(0, 16+16, 0), which is even more weird.
frosch123 added a commit to frosch123/nml that referenced this issue Jun 27, 2023
@frosch123
Fix OpenTTD#295: Adjust version_openttd for OpenTTD >= 12.0.
1026dff
@planetmaker
Copy link
Contributor

How does OpenTTD report its version now in variable 21/A1? According to the specs, it has only one nibble reserved:
https://newgrf-specs.tt-wiki.net/wiki/GlobalVariables#OpenTTD_Version_.2821_.2F_A1.29

@frosch123
Copy link
Member Author

Ah, not even the NFO docs were updated :)
Anyway, meanwhile I made a PR #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@planetmaker @frosch123