Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object company_colour variable points to wrong NFO variable number #256

Closed
JGRennison opened this issue Jun 13, 2022 · 2 comments
Closed

Object company_colour variable points to wrong NFO variable number #256

JGRennison opened this issue Jun 13, 2022 · 2 comments

Comments

@JGRennison
Copy link
Contributor

https://github.com/OpenTTD/nml/blob/master/nml/actions/action2var_variables.py#L657-L658
animation_frame and company_colour are both mapped to the same bits of var 43, which seems wrong.
See also: https://newgrf-specs.tt-wiki.net/wiki/VariationalAction2/Objects#Animation_Counter_.2843.29

The only colour variable is 47 (object colour) which does not have a corresponding NML variable, but this is not really a company colour either.
@glx22
Copy link
Contributor

glx22 commented Jun 13, 2022

Fun fact 7182572 and originally added in 47887a8
BTW I agree it probably should be var 47 and a different name.

@frosch123
Copy link
Member

Industries have a colour variable. I think that name would also fit here.

frosch123 added a commit to frosch123/nml that referenced this issue Sep 10, 2022
@frosch123
Fix OpenTTD#256: Objects have a 'colour' in var 47.
71cb0c9
@frosch123 frosch123 mentioned this issue Sep 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glx22 @JGRennison @frosch123