fix: non-ASCII character breaks remove_trailing_blanks #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
push-kzylpmzxnlyp
branch
from
48894a4 to
5b7fade
Compare
frosch123
force-pushed
the
push-kzylpmzxnlyp
branch
from
5b7fade to
d41975c
Compare
frosch123
approved these changes
Apr 26, 2024
TrueBrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@frosch123 this string breaks
remove_trailing_blanks. The³is a character in our current english.txt, and it is why I found it.Can you pick up this PR and fix it properly? I couldn't figure out 1-2-3 what was actually going on :)