Implement validation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frosch123
commented
Apr 23, 2024
frosch123
commented
- Usage is explained in the readme: https://github.com/frosch123/nile-validator/blob/wip/README.md
- I use the term "dialect" for what nile-config calls "format". "format" sounded like "txt" vs. "json" to me. The values for "dialect" use the same spelling/capitalisation as Bananas.
- There are some bells and whistles left, but otherwise this is complete.
- The commit history is mostly chaos, so squash it is.
TrueBrain
reviewed
Apr 25, 2024
TrueBrain
reviewed
Apr 25, 2024
| } | ||
|
|
||
| /// Replace all ASCII control codes with blank. | ||
| /// Remove trailing blanks at end of each line. |
There was a problem hiding this comment.
Is this meant as doxygen-style comment? Or a reminder to yourself?
Otherwise, can I suggest /** .. */ instead?
There was a problem hiding this comment.
This is meant as rustdoc, which seems to use ///.
| struct StringSignature { | ||
| parameters: HashMap<usize, &'static CommandInfo<'static>>, | ||
| nonpositional_count: BTreeMap<String, (Occurence, usize)>, | ||
| // TODO track color/lineno/colorstack for positional parameters |
There was a problem hiding this comment.
Yes, this is part of the "bells and whistles". Currently stashed.
| config: &LanguageConfig, | ||
| test: &ParsedString, | ||
| base: Option<&ParsedString>, | ||
| ) -> Vec<ValidationError> { |
There was a problem hiding this comment.
This function is over 300 lines long; any chance we can split it up a bit?
There was a problem hiding this comment.
Yes, I am aware. There is also some code duplication with other methods. I need some kind of generator/iterator to loop over commands and figureing out positional parameter references.
Also part of "bells and whistles"
TrueBrain
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.