Codechange: Rewrite grfid to use modernish C++. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
previously approved these changes
Nov 25, 2023
Use standard filestream to read files into a vector and read with an iterator. mmap/munmap is no longer used but that was entirely frivolous.
PeterN
force-pushed
the
grfid-rewrite
branch
from
be13221 to
9aceea2
Compare
glx22
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grfid is based on ancient C code, with non-cross-platform file-handling and Windows support shoe-horned in.
Rewrite to use C++ primitives instead, using standard filestream to read files into a vector and read with an iterator.
mmap/munmap is no longer used but that was entirely frivolous.