Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10198: Rearrange Intro GUI to make button rows narrower #10203

Merged
merged 2 commits into from
Dec 25, 2022

Conversation

2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented Nov 29, 2022

Motivation / Problem

10198

As seen above and described in #10198, the new three-across AI/GS/NewGRF buttons from #10058 can be excessively wide in some languages.

Description

rearranged

Rearrange the buttons to only have two buttons per row (excluding climate selection, of course).

Also makes space for #7786! 😛

Closes #10198

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@2TallTyler 2TallTyler added this to the 13.0 milestone Nov 29, 2022
@2TallTyler 2TallTyler added the size: trivial This Pull Request is trivial label Nov 29, 2022
@JGRennison
Copy link
Contributor

The high score table button is probably the least useful of all the buttons on the main menu, so in that sense it is slightly odd that it is now the biggest.

(Perhaps this button should be moved to some long grass another window entirely?)

@LC-Zorg
Copy link

LC-Zorg commented Nov 30, 2022

It looks good, although the three settings in one line better match the layout in the new game window. It's not possible to use shorter titles?

Anyway, it can also be done in another vertical way. ;)
Vertical main menu

@PeterN
Copy link
Member

PeterN commented Nov 30, 2022

Anyway, it can also be done in another vertical way

Maybe when you use portrait monitor you can use a vertical layout...

@glx22
Copy link
Contributor

glx22 commented Dec 1, 2022

Allowing multiline labels could be enough.
image

@2TallTyler
Copy link
Member Author

Multiline labels is fine by me, although some translator training would be needed. 😃

Copy link
Member

@michicc michicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with re-arranging the buttons, but in the end this or multi-line buttons is better is somewhat of a translator thing.

I wouldn't mind either way.

@2TallTyler 2TallTyler merged commit 4ffe7e0 into OpenTTD:master Dec 25, 2022
@2TallTyler 2TallTyler deleted the intro_gui branch December 25, 2022 18:26
@2TallTyler
Copy link
Member Author

Two columns of buttons is stylistically consistent so I prefer this over multi-line buttons. I hope we'll eventually get #7786 to make the highscore table button an appropriate size again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: trivial This Pull Request is trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Detail]: New main menu looks too wide
6 participants