This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Moved pointer to stay in memory longer #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semi-ix for a conflict in another branch of mine. Needs a few things answered...
|
This is good clean-up, approving and merging this one in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to pull the pointer on each process() loop, this will save a few cycles and fixes a conflict in another branch I am working in.
=> Set gamepad and pGamepad pointers in setup() method
=> Removed pointers from process() loop/method
=> Removed pointer from process() functions
=> Added pointers for gamepad and pGamepad to i2cDisplayAddon class
=> Overall had a great time troubleshooting a loose wire on my breadboard thinking it was a pointer issue for about an hour.....