Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward word wrapping fix #239

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Awkward word wrapping fix #239

merged 6 commits into from
Jul 26, 2022

Conversation

mariah622
Copy link
Contributor

Problem:

Some of the newer campaigns we've added for Sunrise have longer names. Some of these are exhibiting some awkward word-wrapping, e.g:

159747842-dd297e80-838c-47a6-833c-ae7e5f585cef

Solution:

Add word-break styling to campaign title

@paramsiddharth
Copy link
Member

paramsiddharth commented Jun 15, 2022

Looks like what's you're failing here is a formatting check. All you need to do is run:

npm run format
npm run lint

Commit the updated changes and you're good to go.

P.S. If you install the 'Prettier' extension in VSCode and configure it to auto-format for the current workspace, it gets much easier!

@mariah622 mariah622 marked this pull request as ready for review June 15, 2022 20:22
@mariah622 mariah622 requested a review from a team as a code owner June 15, 2022 20:22
paramsiddharth
paramsiddharth previously approved these changes Jun 16, 2022
thyeggman
thyeggman previously approved these changes Jun 29, 2022
@manishapriya94 manishapriya94 enabled auto-merge June 29, 2022 19:47
Copy link
Collaborator

@DietBepis1 DietBepis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mariah, it appears that has that weird word-wrapping from a bug (vuetifyjs/vuetify#9130). For the sake of consistency and best utilization of Vuetify, I would suggest changing the tag into an <h# /> and using one of Vuetify's built-in header classes (https://vuetifyjs.com/en/styles/text-and-typography/).

@mariah622 mariah622 dismissed stale reviews from thyeggman and paramsiddharth via b5fb7ba July 18, 2022 23:22
@DietBepis1
Copy link
Collaborator

Mariah, the new change looks good to me. I think this can be merged. 👍🏽

@paramsiddharth
Copy link
Member

@ProgramEquity/dev-leads Please re-review the PR and merge it. After #265, this PR is mergeable and the tests are passing. @DietBepis1 already approved the PR.

@manishapriya94 manishapriya94 merged commit 0e5c23e into main Jul 26, 2022
@manishapriya94 manishapriya94 deleted the awkward_word_wrapping_fix branch July 26, 2022 17:25
@mariah622 mariah622 linked an issue Aug 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Awkward word-wrapping for campaign names
5 participants