-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awkward word wrapping fix #239
Conversation
Looks like what's you're failing here is a formatting check. All you need to do is run: npm run format
npm run lint Commit the updated changes and you're good to go. P.S. If you install the 'Prettier' extension in VSCode and configure it to auto-format for the current workspace, it gets much easier! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mariah, it appears that has that weird word-wrapping from a bug (vuetifyjs/vuetify#9130). For the sake of consistency and best utilization of Vuetify, I would suggest changing the tag into an <h# /> and using one of Vuetify's built-in header classes (https://vuetifyjs.com/en/styles/text-and-typography/).
Mariah, the new change looks good to me. I think this can be merged. 👍🏽 |
@ProgramEquity/dev-leads Please re-review the PR and merge it. After #265, this PR is mergeable and the tests are passing. @DietBepis1 already approved the PR. |
Problem:
Some of the newer campaigns we've added for Sunrise have longer names. Some of these are exhibiting some awkward word-wrapping, e.g:
Solution:
Add word-break styling to campaign title