Jit the simulation part of lcm #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to tackle Issue #78. Jitting the returned simulation function massively increases the speed of the simulation when repeatedly simulating the same model with different parameters. Additionally the option to
solve&simulateshould consecutively runsolveand thensimulateinstead of creating a combined function to further optimize the execution time.As parts of the simulate function are not jittable, it has to be refactored. Therefore calculating additional targets and constructing the data frame have to be moved outside of
simulate. Furthermore the code for creating the state choice space with sparse choices has to be modified to avoid creating dynamically-shaped arrays, as they can not be traced by JAX.