Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Describe idea of OSI Visualizer #66

Open
wants to merge 1 commit into
base: migration
Choose a base branch
from
Open

Describe idea of OSI Visualizer #66

wants to merge 1 commit into from

Conversation

max-rosin
Copy link

@max-rosin max-rosin commented Jun 4, 2021 •
edited
Loading

This PR resolves #65

Check the checklist

  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • New and existing unit tests / github actions pass locally with my changes.

@max-rosin max-rosin added the documentation Everything which impacts the quality of the documentation and guidelines. label Jun 4, 2021
ThomasNaderBMW
ThomasNaderBMW approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@ThomasNaderBMW ThomasNaderBMW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is good!
Suggestion: You could also mention the filtering mechanisms (you can take a look into the submessages and there fields, what can be really helpful), but also like that it is ok for me :)

@max-rosin max-rosin mentioned this pull request Jun 24, 2021
Open
1 task
@max-rosin
Copy link
Author

@ThomasNaderBMW: I think we should describe how to filter OSI messages. I created an issue to implement that in an upcoming release (#67 )

@max-rosin max-rosin added the ReadyForCCB Ready for Change Control Board label Jun 24, 2021
@stefancyliax stefancyliax removed the ReadyForCCB Ready for Change Control Board label Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThomasNaderBMW ThomasNaderBMW ThomasNaderBMW approved these changes

@clemenshabedank clemenshabedank Awaiting requested review from clemenshabedank

@HendrikAmelunxen HendrikAmelunxen Awaiting requested review from HendrikAmelunxen

@kmeids kmeids Awaiting requested review from kmeids

@pmai pmai Awaiting requested review from pmai

@0815-code 0815-code Awaiting requested review from 0815-code

Assignees
No one assigned
Labels
documentation Everything which impacts the quality of the documentation and guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-rosin @ThomasNaderBMW @stefancyliax