Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid intersection example #54

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

maxmargraf
Copy link
Contributor

@maxmargraf maxmargraf commented Jun 5, 2024

This PR adds an example notebook to the grid intersection functionality.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (61c4063) to head (de6a9f9).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #54    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         4     +1     
  Lines           43       253   +210     
==========================================
+ Hits            43       253   +210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cchwala cchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

Notebook looks great! Also including it in the docs works correctly.

Just one minor comment on the CHANGELOG and one comment on the notebook

This text, which probably stems from the old pycomlink example notebook, is most likely not fitting in the case of the OpenMRG radar data

Note that the lon-lat of the radar grid have been rounded in this example dataset and hence there are some strange pixel size, stemming from the non-equidistant lon-lat grids of the original radar data.

@@ -6,6 +6,9 @@

- [PR 43](https://github.com/OpenSenseAction/poligrain/pull/43) Add code for
finding closest points to lines (by [@eoydvin](https://github.com/eoydvin))
- [PR ](https://github.com/OpenSenseAction/poligrain/pull/54) Add example code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add PR number

@cchwala
Copy link
Member

cchwala commented Jun 5, 2024

Thanks! Merging now.

@cchwala cchwala merged commit a00e083 into OpenSenseAction:main Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants