-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid intersection example #54
Grid intersection example #54
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 4 +1
Lines 43 253 +210
==========================================
+ Hits 43 253 +210 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍
Notebook looks great! Also including it in the docs works correctly.
Just one minor comment on the CHANGELOG and one comment on the notebook
This text, which probably stems from the old pycomlink example notebook, is most likely not fitting in the case of the OpenMRG radar data
Note that the lon-lat of the radar grid have been rounded in this example dataset and hence there are some strange pixel size, stemming from the non-equidistant lon-lat grids of the original radar data.
docs/development/CHANGELOG.md
Outdated
@@ -6,6 +6,9 @@ | |||
|
|||
- [PR 43](https://github.com/OpenSenseAction/poligrain/pull/43) Add code for | |||
finding closest points to lines (by [@eoydvin](https://github.com/eoydvin)) | |||
- [PR ](https://github.com/OpenSenseAction/poligrain/pull/54) Add example code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add PR number
Thanks! Merging now. |
This PR adds an example notebook to the grid intersection functionality.