-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix Delete LICENSES/CC-BY-2.5.txt #581
base: main
Are you sure you want to change the base?
Conversation
As for the use of the CC-BY-2.5 license - it is only applicable to the gitflow.svg file, which was used in the contributor.md file. Since the contributor.md file is now part of the .github repo and no longer in the OpenSTEF repo, we can certainly remove the CC-BY-2.5 file from the LICENSES directory in OpenSTEF repo. Signed-off-by: Jonas van den Bogaard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to remove, please note that the checks are failing.
@JanMaartenvanDoorn Thank you for reviewing and flagging that two checks failed. Since you are more experienced in this domain, do you have any suggestions on how I can ensure those particular checks will pass? I tried following the PR guidelines in the Contributing.md. Also. it is not immediately clear why the Python build failed. |
I had a short look, it seems that there is a failing unit test on main. I will take this up on the community meeting the afternoon. |
Test on main is fixed in #583 |
As for the use of the CC-BY-2.5 license - it is only applicable to the gitflow.svg file, which was used in the contributor.md file. Since the contributor.md file is now part of the .github repo and no longer in the OpenSTEF repo, we can certainly remove the CC-BY-2.5 file from the LICENSES directory in OpenSTEF repo.