Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Delete LICENSES/CC-BY-2.5.txt #581

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jonasvdbo
Copy link
Contributor

As for the use of the CC-BY-2.5 license - it is only applicable to the gitflow.svg file, which was used in the contributor.md file. Since the contributor.md file is now part of the .github repo and no longer in the OpenSTEF repo, we can certainly remove the CC-BY-2.5 file from the LICENSES directory in OpenSTEF repo.

As for the use of the CC-BY-2.5 license - it is only applicable to the gitflow.svg file, which was used in the contributor.md file. Since the contributor.md file is now part of the .github repo and no longer in the OpenSTEF repo, we can certainly remove the CC-BY-2.5 file from the LICENSES directory in OpenSTEF repo.

Signed-off-by: Jonas van den Bogaard <[email protected]>
@Jonasvdbo Jonasvdbo changed the title Delete LICENSES/CC-BY-2.5.txt fix: Delete LICENSES/CC-BY-2.5.txt Jan 2, 2025
Copy link
Collaborator

@JanMaartenvanDoorn JanMaartenvanDoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to remove, please note that the checks are failing.

@Jonasvdbo Jonasvdbo changed the title fix: Delete LICENSES/CC-BY-2.5.txt Bugfix Delete LICENSES/CC-BY-2.5.txt Jan 15, 2025
@Jonasvdbo Jonasvdbo marked this pull request as draft January 15, 2025 10:59
@Jonasvdbo Jonasvdbo marked this pull request as ready for review January 15, 2025 11:00
@Jonasvdbo
Copy link
Contributor Author

@JanMaartenvanDoorn Thank you for reviewing and flagging that two checks failed. Since you are more experienced in this domain, do you have any suggestions on how I can ensure those particular checks will pass? I tried following the PR guidelines in the Contributing.md. Also. it is not immediately clear why the Python build failed.

@JanMaartenvanDoorn
Copy link
Collaborator

@JanMaartenvanDoorn Thank you for reviewing and flagging that two checks failed. Since you are more experienced in this domain, do you have any suggestions on how I can ensure those particular checks will pass? I tried following the PR guidelines in the Contributing.md. Also. it is not immediately clear why the Python build failed.

I had a short look, it seems that there is a failing unit test on main. I will take this up on the community meeting the afternoon.

@lschilders
Copy link
Collaborator

@JanMaartenvanDoorn Thank you for reviewing and flagging that two checks failed. Since you are more experienced in this domain, do you have any suggestions on how I can ensure those particular checks will pass? I tried following the PR guidelines in the Contributing.md. Also. it is not immediately clear why the Python build failed.

I had a short look, it seems that there is a failing unit test on main. I will take this up on the community meeting the afternoon.

Test on main is fixed in #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants