Updated SafeMath from the latest OpenZeppelin code #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepesh-kn
approved these changes
Oct 29, 2018
contracts/lib/SafeMath.sol
Outdated
| @@ -1,6 +1,6 @@ | |||
| pragma solidity ^0.4.23; | |||
| pragma solidity ^0.4.24; | |||
There was a problem hiding this comment.
Other solidity files are using 0.4.23. Should we consider using 0.4.24 in all new files?
There was a problem hiding this comment.
Hm, I don't know. As solidity is developing relatively quickly including the addition of new features, I would say update whatever you work on? What do you think?
There was a problem hiding this comment.
We can keep 0.4.23, and when we plan to upgrade we can create a ticket.
0xsarvesh
reviewed
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/math/SafeMath.sol
Fixes #378