Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] spp_change_request_edit_farm: Create Module #733

Merged
merged 18 commits into from
Feb 19, 2025

Conversation

emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Jan 28, 2025

Why is this change needed?

To Add a CR Type for Edit Farm

How was the change implemented?

Created a Module for CR Type: Edit Farm

New unit tests

TestChangeRequestEditFarm

Unit tests executed by the author

TestChangeRequestEditFarm

How to test manually

  • Install spp_change_request_edit_farm.
  • Create a CR with Edit Farm as the Request Type.
  • Proceed on filling the Fields.
  • Validate and Apply.

Related links

#683

@emjay0921 emjay0921 linked an issue Jan 28, 2025 that may be closed by this pull request
2 tasks
@emjay0921 emjay0921 marked this pull request as ready for review February 11, 2025 01:38
Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emjay0921 Please fix the sonarqubecloud issues specifically the duplicate codes in the tests.

@emjay0921 emjay0921 force-pushed the 683-create-cr-type-edit-group branch from ae00d05 to 2cb5ac0 Compare February 12, 2025 03:48
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 87.64706% with 21 lines in your changes missing coverage. Please review.

Project coverage is 76.06%. Comparing base (7449e59) to head (922069c).
Report is 1 commits behind head on 17.0.

Files with missing lines Patch % Lines
...quest_edit_farm/models/change_request_edit_farm.py 80.58% 16 Missing and 4 partials ⚠️
...ls/change_request_edit_farm_validation_sequence.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #733      +/-   ##
==========================================
+ Coverage   75.97%   76.06%   +0.08%     
==========================================
  Files         749      756       +7     
  Lines       19074    19243     +169     
  Branches     2327     2340      +13     
==========================================
+ Hits        14492    14637     +145     
- Misses       4080     4097      +17     
- Partials      502      509       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emjay0921 emjay0921 force-pushed the 683-create-cr-type-edit-group branch from 97a252b to e1a8b61 Compare February 13, 2025 03:59
@gonzalesedwin1123 gonzalesedwin1123 merged commit 0df4905 into 17.0 Feb 19, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@gonzalesedwin1123 gonzalesedwin1123 deleted the 683-create-cr-type-edit-group branch February 19, 2025 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CR type edit-group
3 participants