Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] spp_change_request_edit_farmer #727

Merged
merged 8 commits into from
Feb 18, 2025

Conversation

emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Jan 21, 2025

Why is this change needed?

To add a CR for Editing a Farmer

How was the change implemented?

Created a new Module for CR Edit Farmer Type

New unit tests

TestChangeRequestEditFarmer

Unit tests executed by the author

TestChangeRequestEditFarmer

How to test manually

  • Install spp_change_request_edit_farmer.
  • Create a Change Request with Edit Farmer as the Request Type.
  • Fill the fields needed.
  • Validate and Apply.

Related links

#684

@emjay0921 emjay0921 linked an issue Jan 21, 2025 that may be closed by this pull request
2 tasks
@emjay0921 emjay0921 marked this pull request as ready for review February 11, 2025 01:35
Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emjay0921 Please fix the sonarqubecloud issues specifically the duplicate codes in the tests.

@emjay0921 emjay0921 force-pushed the 684-create-cr-type-edit-farmer branch from 55ba9ad to 89135c2 Compare February 12, 2025 01:07
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 82.48588% with 31 lines in your changes missing coverage. Please review.

Project coverage is 75.78%. Comparing base (272c2e2) to head (2dbdc69).
Report is 11 commits behind head on 17.0.

Files with missing lines Patch % Lines
...t_edit_farmer/models/change_request_edit_farmer.py 75.80% 20 Missing and 10 partials ⚠️
.../change_request_edit_farmer_validation_sequence.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #727      +/-   ##
==========================================
+ Coverage   75.72%   75.78%   +0.05%     
==========================================
  Files         735      742       +7     
  Lines       18885    19062     +177     
  Branches     2324     2345      +21     
==========================================
+ Hits        14301    14446     +145     
- Misses       4086     4106      +20     
- Partials      498      510      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonzalesedwin1123 gonzalesedwin1123 merged commit 646bbe2 into 17.0 Feb 18, 2025
7 checks passed
@gonzalesedwin1123 gonzalesedwin1123 deleted the 684-create-cr-type-edit-farmer branch February 18, 2025 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CR type edit-farmer
3 participants