Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add button to show all cycle members #655

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

emjay0921
Copy link
Contributor

Why is this change needed?

To be able to view all members (Even non-compliant members) on Cycle View.

How was the change implemented?

Added a button and function to open the list of members without the added filter, also added a new count field to count all members.

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Install or Upgrade spp_programs_compliance_criteria.
  • Open or Create new program (Make sure to add some compliance criteria).
  • Open or Create new cycle.
  • Check if Enrollments Button on top (Before Beneficiaries) exists.
  • Click on Compliance Criteria and check if the Enrollments Count is still the same.
  • Compare the List from Beneficiaries and Enrollments if it is the expected behavior.

Related links

#649

Copy link

sonarqubecloud bot commented Nov 4, 2024

@reichie020212
Copy link
Member

LGTM. Thanks @emjay0921

@emjay0921 emjay0921 merged commit 0501c8e into 17.0 Nov 11, 2024
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate between eligible and compliant when using compliance module
3 participants