Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved showing of error in vci module #619

Merged
merged 10 commits into from
Nov 22, 2024
Merged

improved showing of error in vci module #619

merged 10 commits into from
Nov 22, 2024

Conversation

reichie020212
Copy link
Member

Why is this change needed?

Upon printing the vci issuer, the invoice is printed instead of vci issuer and this is happening on a random occasion

How was the change implemented?

Now, I added an argument config=False so that it will always go to the vci issuer

How to test manually

  • Install module spp_openid_vci_individual
  • Go to settings and click Activate the developer mode
  • Go to Settings -> User & Companies -> Users.
  • Enter the record Administrator.
  • Go to Access Rights tab and check the Crypto Admin Role
  • Refresh the page. You should now be able to see the Encryption Providers Menu on top of the page. Click that menu.
  • Enter the Default encryption provider record.
  • In Type field, select the JWCrypto then Click the button Create Jwcrpyto Key then Save.
  • Go to VCI Issuer menu and create a record.
  • Fillup only the following: Name, Scope, Issuer Type, Supported Format, Encryption Provider, and Auth Subject ID Type
  • Upon saving, other fields will be automatically fill-up.
  • Go to Registry -> Individuals and create or update a record.
  • Make sure the the Individual have an ID type with the same ID Type selected in Auth Subject ID Type
  • Click the Issue Card button in the top-middle of the page.
  • Select the Issuer that was created earlier then click Confirm.
  • There should be a downloaded pdf file for vci issuer.

Related links

#372

@reichie020212 reichie020212 linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (26fe80a) to head (0e917a8).
Report is 3 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_openid_vci/tools/tools.py 82.85% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             17.0     #619    +/-   ##
========================================
  Coverage   72.74%   72.75%            
========================================
  Files         618      667    +49     
  Lines       16455    17241   +786     
  Branches     2116     2189    +73     
========================================
+ Hits        11971    12544   +573     
- Misses       4097     4297   +200     
- Partials      387      400    +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@reichie020212 reichie020212 merged commit b3c00ad into 17.0 Nov 22, 2024
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VC Implementation
3 participants