db_text: new parameter: buffer_size #3352
Conversation
| @@ -125,6 +126,12 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) | |||
| if(!fin) | |||
| return NULL; | |||
|
|
|||
| buf = pkg_malloc(buffer_size); | |||
There was a problem hiding this comment.
@ovidiusas , wouldn't be worthy to have this buf as static var in the function, so we can allocate it upon first usage and keep re-use it for the whole runtime? Instead of keep allocating and freeing it after each load....
There was a problem hiding this comment.
We could, but this would leave us with unused memory. The buffer is used only during init and during a db reload.
If we make the buffer static, then the buffer will be replicated into all running procs and wasted there.
Before, the buffer was part of the stack and now it will be part of the pkg memory.
We have max 2 pkg mem allocations per table/file (one for version and one for the table itself).
I don't think that we will gain to much (in terms of speed) by making it static. I would prefer to avoid wasting memory.
|
@bogdan-iancu Any updates here? |
|
@ovidiusas , could you remove the |
|
Done! |
Summary
New parameter for db_text: buffer_size.
This will allow db_text to handle larger text files.