perbaikan select epidemi penyakit #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andifahruddinakas
requested changes
May 25, 2022
Comment on lines
14
to
18
| @if($epidemi->penyakit_id == $key) | ||
| <option selected value="{{ $key }}">{{ $penyakit }}</option> | ||
| @else | ||
| <option value="{{ $key }}">{{ $penyakit }}</option> | ||
| @endif |
There was a problem hiding this comment.
Gunakan @selected, cek komentar issue apa yg disarankan #400 (comment)
There was a problem hiding this comment.
mas @andifahruddinakas sudah dipush kembali, tolong direview apa sudah sesuai
andifahruddinakas
requested changes
May 25, 2022
| @@ -11,7 +11,7 @@ | |||
| <div class="col-md-8"> | |||
| <select class="form-control" id="penyakit_id" name="penyakit_id"> | |||
| @foreach($jenis_penyakit as $key=>$penyakit) | |||
| <option value="{{ $key }}">{{$penyakit}}</option> | |||
| <option value="{{ $key }}" {{ old('penyakit_id', $epidemi->penyakit_id) == $key ? 'selected' : null}}>{{ $penyakit }}</option> | |||
|
Mas @devrakapriyo, silahkan diperbaiki PR ini sesuai yang diharapkan. |
Pagi mas @andifahruddinakas tolong direview lagi, sudah ditambahkan blade @selected |
|
Pak @eddieridwan, ini sudah ok. |
|
@all-contributors please add @devrakapriyo for code |
|
I've put up a pull request to add @devrakapriyo! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#400