Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --skip-validation option synonym for --skip-valid #1689

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

evgenyz
Copy link
Contributor

@evgenyz evgenyz commented Feb 16, 2021

First step on the way to deprecate and then remove misleading option --skip-valid (why on earth should we skip something that is valid?).

First step on the way to deprecate and then remove misleading option
--skip-valid (why on earth should we skip something that is valid?).
@jan-cerny jan-cerny self-assigned this Feb 16, 2021
@jan-cerny
Copy link
Member

@evgenyz What about deprecating it right now? I mean keep --skip-valid working, but document it as deprecated and prefer --skip-validation everywhere.

@evgenyz
Copy link
Contributor Author

evgenyz commented Feb 16, 2021

@evgenyz What about deprecating it right now? I mean keep --skip-valid working, but document it as deprecated and prefer --skip-validation everywhere.

I'm not against deprecating it in the documentation (I kind of already moved the accent away from it in this PR), but emission of a warning could break some tests. Also I changed all --skip-valid invocations in the project to --skip-validation.

@jan-cerny
Copy link
Member

It is a known issue: actions/runner-images#2703 and they say they will roll out new image soon.

@evgenyz
Copy link
Contributor Author

evgenyz commented Feb 16, 2021

It is a known issue: actions/virtual-environments#2703 and they say they will roll out new image soon.

QA? No, never heard about it.

@jan-cerny jan-cerny added this to the 1.3.5 milestone Feb 17, 2021
@jan-cerny jan-cerny merged commit c9bd416 into OpenSCAP:maint-1.3 Feb 17, 2021
@evgenyz evgenyz deleted the skip-validation branch March 16, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants