Fix review - require funder equals issuer#116

Merged

FlacoJones merged 37 commits intoauditfrom fix-review-require-funder-equals-issuer

Feb 28, 2023

+61-3,681

Commits on Feb 25, 2023

removes all traces of Ongoing and TieredPercentage bounties, including the Ongoing+TieredPercentage implementations, interfaces, and methods in OpenQV1 and ClaimManagerV1
FlacoJones
committed
updates BountyFactory test to operate without Ongoing or TieredPercentage
FlacoJones
committed
updates ClaimManager tests to pass without Ongoing or TieredPercentage
FlacoJones
committed
updates DepositManager test to run without Ongoing or TieredPercentage bounty types
FlacoJones
committed
updates OpenQ test to pass without Ongoing or TieredPercentage bounty types
FlacoJones
committed
udpates TieredBountyCore tests to pass without Ongoing or TieredPercentage
FlacoJones
committed
updates deploy scripts to operate without Ongoing or TieredPercentage
FlacoJones
committed
removes TOKEN_ADDRESS_LIMIT from TokenWhitelist.sol
FlacoJones
committed
removes the check of token address limit on DepositManager. simply requires token is whitelisted, or reverts
FlacoJones
committed
removes tokenAddressLimitReached in DepositManager
FlacoJones
committed
updates OpenQTokenWhitelist tests to pass without TOKEN_ADDRESS_LIMIT
FlacoJones
committed
updates deploy script for OpenQTokenWhitelist being initialized without a token address limit
FlacoJones
committed
removes deprecated tests in DepositManager.test.js related to TOKEN_ADDRESS_LIMIT, simply checks if token is whitelisted or not
FlacoJones
committed
updates OpenQ.test.js to deploy OpenQTokenWhitelist without TOKEN_ADDRESS_LIMIT in constructor
FlacoJones
committed
further updates tests to deploy OpenQTokenWhitelist without TOKEN_ADDRESS_LIMIT in the constructor
FlacoJones
committed
removes nft logic from AtomicBountyV1.sol
FlacoJones
committed
removes nft logic from BountyCore.sol
FlacoJones
committed
removes NFT logic from TieredBountyCore
FlacoJones
committed
removes nftDepositLimit from TieredFixedBountyV1.sol
FlacoJones
committed
removes nft interface methods from IBountyCore.sol
FlacoJones
committed
removes logic that looped over nft deposits to transfer on claims
FlacoJones
committed
removes nft funding logic from DepositManagerV1
FlacoJones
committed
removes unused NFT related error messages from Errors.sol
FlacoJones
committed
removes MockNFT contract
FlacoJones
committed
updates DepositManager.test.js to remove nft related tests
FlacoJones
committed
removes nft related tests from ClaimManager.test.js
FlacoJones
committed
removes nft related tests from OpenQ.test.js
FlacoJones
committed
updates deploy contract script to remove nft related logic
FlacoJones
committed
removes MockNFt from fund_bounties script
FlacoJones
committed
removes nft logic from AtomicBountyV1.test.js
FlacoJones
committed
removes nft logic from BountyCore and TieredBountyCore tests
FlacoJones
committed
removes nft logic from all tests
FlacoJones
committed
removes ERC721Receiver imports from BountyStorageCore.sol
FlacoJones
committed
allows for funding of contracts even after close in the case that further funds are needed after a winner claims a tier
FlacoJones
committed
removes bountyIsOpen method from DepositManager
FlacoJones
committed
removes test in DepositManager that formerly prevented funding after competition close
FlacoJones
committed

Commits on Feb 26, 2023

adds require(isWhitelisted(_tokenAddress), Errors.TOKEN_NOT_ACCEPTED); to fundBountyToken
FlacoJones
committed