Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix review - removes all traces of Ongoing and TieredPercentage bounty types #112

Merged
merged 7 commits into from
Feb 28, 2023

Conversation

FlacoJones
Copy link
Contributor

@FlacoJones FlacoJones commented Feb 25, 2023

Removes the following contracts:

  • OngoingBountyV1.sol
  • TieredPercentageBountyV1.sol
  • ITieredPercentageBounty.sol
  • IOngoingBounty.sol
  • OngoingBountyStorage.sol
  • TieredPercentageBountyStorage.sol

Removes the following parameters from dependencies:

  • BountyFactory::constructor removes _ongoingBountyBeacon and _tieredPercentageBountyBeacon

Removes the following constants from OpenQDefinitions.sol:

  • uint32 internal constant ONGOING = 1;
  • uint32 internal constant TIERED_PERCENTAGE = 2;

Removes the following methods from OpenQV1.sol:

  • setPayout
  • setPayoutSchedule
  • closeOngoing
  • solvent
  • ongoingClaimed

Removes the following methods from ClaimManagerV1.sol:

  • _eligibleToClaimOngoingBounty
  • _claimOngoingBounty
  • _claimTieredPercentageBounty
  • bountyIsClaimable

Removes several if/else blocks in ClaimManagerV1.sol which previously called the internal _claim methods based on the bounty type equalling Ongoing or TieredPercentage

Adds function payoutTokenAddress() external returns (address); to ITieredFixedBounty.sol which was previously exposing the payoutTokenAddress storage variable via inheritance of the IOngoingBounty.sol which is now deprecated

Updates tests to pass without the Ongoing or TieredPercentage bounty types

Removes one test in DepositManager.test.js that checks that funding is not possible if the bounty is closed. This requirement will be removed in a follow up fix PR which you can find here

This was referenced Feb 25, 2023
Copy link

@IAm0x52 IAm0x52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you got everything. Will keep my eye out when reviewing the rest of the PRs for anything that might have been missed

@FlacoJones FlacoJones merged commit c14e922 into audit Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants