-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix review - removes all traces of Ongoing and TieredPercentage bounty types #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the Ongoing+TieredPercentage implementations, interfaces, and methods in OpenQV1 and ClaimManagerV1
This was referenced Feb 25, 2023
This was referenced Feb 26, 2023
IAm0x52
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you got everything. Will keep my eye out when reviewing the rest of the PRs for anything that might have been missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the following contracts:
OngoingBountyV1.sol
TieredPercentageBountyV1.sol
ITieredPercentageBounty.sol
IOngoingBounty.sol
OngoingBountyStorage.sol
TieredPercentageBountyStorage.sol
Removes the following parameters from dependencies:
BountyFactory::constructor
removes_ongoingBountyBeacon
and_tieredPercentageBountyBeacon
Removes the following constants from
OpenQDefinitions.sol
:uint32 internal constant ONGOING = 1;
uint32 internal constant TIERED_PERCENTAGE = 2;
Removes the following methods from
OpenQV1.sol
:setPayout
setPayoutSchedule
closeOngoing
solvent
ongoingClaimed
Removes the following methods from
ClaimManagerV1.sol
:_eligibleToClaimOngoingBounty
_claimOngoingBounty
_claimTieredPercentageBounty
bountyIsClaimable
Removes several
if/else
blocks inClaimManagerV1.sol
which previously called the internal_claim
methods based on the bounty type equalling Ongoing or TieredPercentageAdds
function payoutTokenAddress() external returns (address);
toITieredFixedBounty.sol
which was previously exposing thepayoutTokenAddress
storage variable via inheritance of theIOngoingBounty.sol
which is now deprecatedUpdates tests to pass without the Ongoing or TieredPercentage bounty types
Removes one test in
DepositManager.test.js
that checks that funding is not possible if the bounty is closed. This requirement will be removed in a follow up fix PR which you can find here