Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: Fix cupsd activated on-demand via socket (fixes #985) #987

Closed
wants to merge 1 commit into from

Conversation

zdohnal
Copy link
Member

@zdohnal zdohnal commented Jun 17, 2024

If only the expected cups.sock is set as listener in cupsd.conf, the array Listeners was NULL. To prevent copying the code, do the array allocation earlier and have only one check for Listeners, in service_checkin() which is run every time cupsd starts.

Fixes #985

…ng#985)

If only cups.sock is set as listener in cupsd.conf, the array Listeners
was NULL. To prevent copying the code, move the array allocation earlier
and have only one check for Listeners, in `service_checkin()` which is
run every time cupsd starts.

Fixes OpenPrinting#985
Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments for PR #988.

@zdohnal
Copy link
Member Author

zdohnal commented Jun 18, 2024

Fixed by 74f437b7d .

@zdohnal zdohnal closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.4.9 regression] cupsd don't start when only Listen /path/to/domain/socket is set in conf
2 participants