-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imagetoraster crashed on signal 6 #507
Comments
Backtrace:
|
Ha! Removing
fixes the issue. I can print now. test image printed correctly. But still, the ppd was created automatically by cups, I would expect it creates ppd that works... Is that cupsFilter2 important? |
The library-internal _cfImageZoom...() API handles zooming of images with a data structure of type cf_izoom_t. This data structure contains a pointer to the original image, in cf_image_t format. The _cfImageZoomNew() funtion gets a pointer to an existing cf_image_t structure as parameter, the image to work on. It stores the pointer in its cf_izoom_t structure. It never creates a cf_image_t image. Because the _cfImageZoom...() API never creates a cf_image_t structure, it should also never free it. Therefore it is wrong that _cfImageZoomDelete() calls cfImageClose() which is the function to free a cf_image_t structure after use. This was leading to double freeing, as the functions which create a cf_image_t structure always free it when done. This caused OpenPrinting/cups-filters#507
Thanks a lot @sourabh1952 for your investigations on this bug! With this I fixed it in libcupsfilters (2.x) now, commit OpenPrinting/libcupsfilters@381636a :
|
I'm sorry for this regression :( it's a bad habit to think all structs are allocated in *New() functions and don't check which are actually allocated as new and which are only referenced to already allocated pointer. I hope everything is alright now. |
Describe the bug
imagetoraster crashes on signal 6 when printing to Xerox printer using IPP:
munmap_chunk(): invalid pointer
To Reproduce
Steps to reproduce the behavior:
The .ppd file:
Expected behavior
No crash. Image printed.
System Information:
The text was updated successfully, but these errors were encountered: