deps: Update to NiiVue to 0.45.1 #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add workaround for module resolver differences between vitest and vite
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
=======================================
Coverage 44.03% 44.03%
=======================================
Files 593 593
Lines 37807 37807
Branches 1125 1125
=======================================
Hits 16647 16647
Misses 20958 20958
Partials 202 202 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workaround for module resolver differences between vitest and vite.
Failure from #3056 comes down to vitest not using the same optimizer for vite when loading this module. This workaround gets tests passing and newer Niivue was already working in Vite 5/6 when run in the browser.