Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker): Allow indexing URLs from a whitelist of S3 buckets #3138

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Sep 5, 2024

This is the simplest version of allowing S3 buckets not configured by OpenNeuro to display URLs to the front end.

For future work, we will need to index and test remotes, then warn the uploader and disable versioning/publishing until an accessible copy of all objects is present to allow minting a DOI.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.06%. Comparing base (4e58a68) to head (23b89a1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3138      +/-   ##
==========================================
- Coverage   44.07%   44.06%   -0.01%     
==========================================
  Files         593      593              
  Lines       37749    37750       +1     
  Branches     1124     1124              
==========================================
  Hits        16636    16636              
- Misses      20911    20912       +1     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 5ff1914 into master Sep 5, 2024
10 checks passed
@nellh nellh deleted the s3-bucket-whitelist branch September 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant