Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): participantCount query should match all instead of only most significant modalities #3126

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 19, 2024

If the validator has matched a modality, include it in the participant count. Search was already adjusted to follow this behavior, this aligns the participant count values with the search query results.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (dd5e5ff) to head (ae11504).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
- Coverage   73.63%   73.57%   -0.07%     
==========================================
  Files          45       45              
  Lines        1631     1631              
==========================================
- Hits         1201     1200       -1     
- Misses        430      431       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 718aec2 into master Aug 19, 2024
5 of 10 checks passed
@nellh nellh deleted the modality-subject-count-fix branch August 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant