Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): Allow commit summaries (snapshot API) with no files #3086

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jun 22, 2024

The 404 here didn't really make sense because it would fail if get_tree returned a tree with no files. That's a valid tree, so it should return the 200 case.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.82%. Comparing base (79b32ba) to head (598b5b2).

Files Patch % Lines
...ices/datalad/datalad_service/handlers/snapshots.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3086       +/-   ##
===========================================
+ Coverage   42.36%   72.82%   +30.46%     
===========================================
  Files         595       43      -552     
  Lines       37921     1608    -36313     
  Branches     1096        0     -1096     
===========================================
- Hits        16064     1171    -14893     
+ Misses      21645      437    -21208     
+ Partials      212        0      -212     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit b9a3b15 into master Jun 22, 2024
10 of 11 checks passed
@nellh nellh deleted the empty-snapshot-bug branch June 22, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant