Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Apply default search parameters on any initial render #3045

Merged
merged 1 commit into from
May 8, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented May 6, 2024

Fixes an issue where the portal pages would not have any search parameters applied. The search container itself is only recreated when changing modalities (since this remounts the component), so otherwise parameters are maintained without the useEffect call.

See #3043

Fixes an issue where the portal pages would not have any search parameters applied.
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 42.48%. Comparing base (651263d) to head (cbc11d4).

Files Patch % Lines
...nneuro-app/src/scripts/search/search-container.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3045   +/-   ##
=======================================
  Coverage   42.48%   42.48%           
=======================================
  Files         601      601           
  Lines       37969    37967    -2     
  Branches     1113     1113           
=======================================
  Hits        16131    16131           
+ Misses      21622    21620    -2     
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit cd5c1e0 into master May 8, 2024
10 of 11 checks passed
@nellh nellh deleted the 3043-default-portal-search-params branch May 8, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant