Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Disable derivatives tab if ToS not accepted #2994

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

effigies
Copy link
Contributor

It seems somewhat inconsistent that we tell people how to get derivatives but not raw data if they haven't agreed not to attempt to reidentify participants.

image

I think this is as simple as my proposed change. Open to arguments if you think this doesn't matter as much.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 65.25%. Comparing base (a5269a4) to head (1be2211).

Files Patch % Lines
...uro-app/src/scripts/dataset/routes/derivatives.tsx 25.00% 6 Missing ⚠️
...pp/src/scripts/dataset/components/DatasetTools.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2994      +/-   ##
==========================================
- Coverage   65.27%   65.25%   -0.02%     
==========================================
  Files         382      382              
  Lines       24594    24603       +9     
  Branches      883      883              
==========================================
+ Hits        16053    16055       +2     
- Misses       8541     8548       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the enh/gray-derivatives branch from 8a81110 to 1be2211 Compare February 28, 2024 19:32
@effigies effigies changed the title ENH: Disable derivatives tab if ToS not accepted enh(app): Disable derivatives tab if ToS not accepted Feb 29, 2024
@effigies effigies changed the title enh(app): Disable derivatives tab if ToS not accepted feat(app): Disable derivatives tab if ToS not accepted Feb 29, 2024
@nellh nellh merged commit 78835de into OpenNeuroOrg:master Feb 29, 2024
6 of 8 checks passed
@effigies effigies deleted the enh/gray-derivatives branch February 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants