Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API crash caused by socket closed errors #2959

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Dec 13, 2023

A request for a deleted dataset tree object could cause a crash due to unhandled errors opening the repository. This changes both the worker and the API to handle this situation better and return more sensible HTTP 404 errors when requesting trees or datasets that do not exist.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (86ef124) 65.08% compared to head (7ce531f) 72.61%.
Report is 2 commits behind head on master.

Files Patch % Lines
services/datalad/datalad_service/handlers/files.py 76.47% 4 Missing ⚠️
services/datalad/datalad_service/handlers/tree.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2959      +/-   ##
==========================================
+ Coverage   65.08%   72.61%   +7.53%     
==========================================
  Files         378       43     -335     
  Lines       24309     1607   -22702     
  Branches      884        0     -884     
==========================================
- Hits        15822     1167   -14655     
+ Misses       8487      440    -8047     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 48fb0d8 into master Dec 13, 2023
7 checks passed
@nellh nellh deleted the fix/missing-files-socket-closed-bugs branch December 13, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant