-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ORCID member API for authentication #2728
Conversation
This is deployed on staging at the moment, so it can be tested with a sandbox.orcid.org account (you must verify the mailinator address to test). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2728 +/- ##
==========================================
+ Coverage 42.36% 42.62% +0.26%
==========================================
Files 595 592 -3
Lines 37919 37857 -62
Branches 1096 1098 +2
==========================================
+ Hits 16063 16137 +74
+ Misses 21644 21513 -131
+ Partials 212 207 -5 ☔ View full report in Codecov by Sentry. |
Thanks for testing @effigies, I'm going to hold off on merging this until I have the production deployment time scheduled with ORCID. |
…rements Error messages encourage users to use the less public "trusted institutions" settings for OpenNeuro's required fields.
This now only requires a user to make the ORCID fields available to trusted institutions. Error messages are improved to not encourage users to make these fields public unnecessarily.
Fixes #2660