Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all versions of the log stream names after Batch API changes #17

Merged
merged 5 commits into from
Aug 29, 2017

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 29, 2017

This solves issue #12. There's three situations to handle here.

  1. Jobs run prior to 2017-08-21T14:00-07:00. These use the old log stream names in CloudWatch and are correct. These need to be served without changes.
  2. Jobs run prior to pulling in this fix but after the August 21st date. These use the old log stream name internally but CloudWatch uses the new format.
  3. Jobs run after this branch is merged. These store the new CloudWatch stream name format.

All of these should have accessible logs (for individual tasks or download all) with these changes.

@nellh nellh requested a review from jstiehl August 29, 2017 19:34
Copy link
Contributor

@jstiehl jstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. My broken logs were fixed on refresh on my local machine. Ran a new job and the logs were available. Ran tests locally and all looked good.

@nellh nellh merged commit f33c349 into master Aug 29, 2017
@nellh nellh deleted the logstream-name-fix branch August 31, 2017 22:46
nellh added a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants