Merge pull request #2964 from OpenNeuroOrg/fix/handle-worker-restarts

fix(api): Prevent crash when tree is requested with no children
OpenNeuroOrg · Jan 4, 2024 · 595896d · 595896d
2 parents 34d3991 + 06f7061
commit 595896d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/openneuro-server/src/handlers/datalad.ts b/packages/openneuro-server/src/handlers/datalad.ts
@@ -29,7 +29,10 @@ export const getFile = async (req, res) => {
       if (level == pathComponents.slice(-1)) {
         file = files.find((f) => !f.directory && f.filename === level)
       } else {
-        tree = files.find((f) => f.directory && f.filename === level).id
+        // This tree may exist but have no children
+        if (files) {
+          tree = files.find((f) => f.directory && f.filename === level).id
+        }
       }
     } catch (err) {
       // ConnectTimeoutError is Node/Undici and TimeoutError is the standard DOMException name