This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Support ID_LIKE in /etc/os-release if it exists #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Useful for unsupported distributions based off supported distributions Signed-off-by: Cody Robertson <[email protected]>
dann1
reviewed
Apr 24, 2023
Signed-off-by: Cody Robertson <[email protected]>
dann1
approved these changes
Apr 25, 2023
dann1
added a commit
that referenced
this pull request
May 4, 2023
rsmontero
pushed a commit
that referenced
this pull request
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example use case is we utilize CloudLinux for a handful of servers, a commercial distribution based on RHEL. Since CloudLinux isn't supported by OpenNebula officially, it breaks some context functions, such as the network, due to how OS detection works.
This change proposes the
detect_osfunction used to determine which OS it's the script is being run on and also sends along theID_LIKEvariable in the/etc/os-releasefile if it exists. Then we can loop over theID_LIKEdistributions to see if anything matches if theIDfield doesn't match a supported OS.No other context scripts rely on the
detect_oshelper function, so it should be safe to adjust what it returns without breaking other context scripts.