This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
F #260: Allow not mounting Swap automatically #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Th0masL
changed the title
Signed-off-by: Thomas Lejeune <[email protected]>
Th0masL
changed the title
|
To address #260 |
ospalax
reviewed
May 3, 2022
| @@ -21,6 +21,10 @@ if [ "$1" != 'local' ] ; then | |||
| exit 0 | |||
| fi | |||
|
|
|||
| if [ "${DISABLE_SWAP}" == "true" ]; then | |||
There was a problem hiding this comment.
We use YES, yes, NO, no as the boolean values in the context.
There was a problem hiding this comment.
The context parameter DISABLE_SWAP is misleading - swap can still be enabled if there is correct line in /etc/fstab for example - this script is looking for block devices with a type SWAP and mounts them (if on linux) - I think that a better name but still short is IGNORE_SWAP.
|
Closed in favor of this PR: #262 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
DISABLE_SWAPwith the valuetrueto prevent theone-context.dscripts to automatically try to mount the Swap file