This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Fix some errors in FreeBSD 13 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In case the CD-ROM is not mounted "glabel status | grep CONTEXT | awk '{print $3}'"
will have a null string which will eventually assign the value "/dev/" to "dev_context"
variable. In later occasions while existence of "dev_context" is checked it will
always return true and no elif conditions will be executed. Add additional glabel check
for BSD.
- In case the CD-ROM is not mounted and used there is nothing to unmount and eventually
trying to unmount will throw error. So add an additional check to see if "MOUNT_DIR" is
used as any mount points or not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will have a null string which will eventually assign the value "/dev/" to "dev_context"
variable. In later occasions while existence of "dev_context" is checked it will
always return true and no elif conditions will be executed. Add additional glabel check
for BSD.
trying to unmount will throw error. So add an additional check to see if "MOUNT_DIR" is
used as any mount points or not.
Changes proposed in this pull request: