Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Setup timezone #165

Closed
kvaps opened this issue Jun 27, 2019 · 5 comments · Fixed by #166
Closed

Setup timezone #165

kvaps opened this issue Jun 27, 2019 · 5 comments · Fixed by #166

Comments

@kvaps
Copy link
Contributor

kvaps commented Jun 27, 2019

It would be nice to have ability to setup timezone in contextualization scripts

kvaps added a commit to kvaps/addon-context-linux that referenced this issue Jun 27, 2019
kvaps added a commit to kvaps/addon-context-linux that referenced this issue Jun 27, 2019
kvaps added a commit to kvaps/addon-context-linux that referenced this issue Jun 27, 2019
vholer pushed a commit that referenced this issue Jun 28, 2019
@vholer vholer reopened this Jun 28, 2019
@vholer
Copy link
Contributor

vholer commented Jun 28, 2019

Reopening, pending tasks on our side:

@kvaps
Copy link
Contributor Author

kvaps commented Jun 28, 2019

Also consider to add tzdata to the package dependencies (eg. alpine have no tzdata installed from the beginning)

@kvaps
Copy link
Contributor Author

kvaps commented Jun 28, 2019

UPD: most of packages in alpine uses strategy to be installed on demand. Eg: openssl can be installed during the boot same way, if you need to decrypt apkovl file. We can use the same strategy to run apk add tzdata if TIMEZONE variable is set

@vholer
Copy link
Contributor

vholer commented Jun 28, 2019

Similar concern we had with the Ruby dependencies for the OneGate (#125). I'm not happy with bringing all as hard dependencies, but more I don't like ad-hoc installing of something, as it requires working public networking. In case of timezone data, I would say we could avoid this dependency and leave it on the user who is building the image.

At least, the contextualization script should provide some error in the log if requested timezone is not defined. Right now, it would skip silently.

@vholer
Copy link
Contributor

vholer commented Sep 13, 2019

We have support for timedatectl, we have tests, we have similar feature for Windows, we have updated docs. On Alpine, I'm not adding dependency on tzdata, leaving this completely on user who is building the image.

Closing.

@vholer vholer closed this as completed Sep 13, 2019
vholer pushed a commit that referenced this issue Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants